Improve error printing in contract validator #5596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #5596 +/- ##
==========================================================
- Coverage 55.92% 55.90% -0.03%
==========================================================
Files 1049 1049
Lines 103232 103232
==========================================================
- Hits 57733 57707 -26
- Misses 41111 41128 +17
- Partials 4388 4397 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SupunS
force-pushed
the
supun/improve-contract-errors
branch
from
5f3081d to
e6b0fdf
Compare
turbolent
changed the base branch from
feature/stable-cadence
to
auto-update-onflow-cadence-v1.0.0-preview.18
…n/improve-contract-errors
|
@SupunS Is this PR only in draft because it depends on another PR, or is there still other work required? |
|
Was in draft until the flow-go gets updated with the cadence release |
Base automatically changed from
auto-update-onflow-cadence-v1.0.0-preview.18
to
feature/stable-cadence
March 27, 2024 23:31
turbolent
reviewed
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #5600
Looks like without providing the codes, the secondary errors are not getting printed.